Bug 284139
| Summary: | Callers of RenderStyle::setFontDescription() should not have to manually call fontCascade().update() | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> |
| Component: | Layout and Rendering | Assignee: | Simon Fraser (smfr) <simon.fraser> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bfulgham, simon.fraser, webkit-bug-importer, zalan |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Other | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 267252 | ||
Simon Fraser (smfr)
`RenderStyle::setFontDescription()` is written in a way that requires callers to subsequently call `fontCascade().update()`, because `setFontDescription` computes a new FontCascade that is lacking a FontCascadeFonts. A call to update() is needed to compute the fonts.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/141019117>
Simon Fraser (smfr)
Pull request: https://github.com/WebKit/WebKit/pull/37523
EWS
Committed 287465@main (68c05597505a): <https://commits.webkit.org/287465@main>
Reviewed commits have been landed. Closing PR #37523 and removing active labels.