Bug 284070

Summary:	Unable to reasonably test AutoInstaller (because it is a singleton)
Product:	WebKit	Reporter:	Sam Sneddon [:gsnedders] <gsnedders>
Component:	New Bugs	Assignee:	Nobody <webkit-unassigned>
Status:	NEW
Severity:	Normal	CC:	jbedard, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Sam Sneddon [:gsnedders]

Reported 2024-12-04 15:19:41 PST

At the moment, writing any sort of unit tests for the AutoInstaller is very difficult — because it's a singleton, and thus changing any state changes behaviour for everything. There's no strong reason for it to be a singleton — one could imagine multiple active AutoInstaller on the meta search path, each with different packages registered. We should make it into a normal class, with webkitcorepy.AutoInstaller a "default" instance.

Attachments
Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2024-12-04 15:19:51 PST

<rdar://problem/140941076>

Note You need to log in before you can comment on or make changes to this bug.