Bug 284001
| Summary: | resolveForDocument() should explicitly set the FontCascade on the style | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> |
| Component: | CSS | Assignee: | Simon Fraser (smfr) <simon.fraser> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | koivisto, simon.fraser, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Other | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 267252 | ||
Simon Fraser (smfr)
Currently, resolveForDocument () does:
documentStyle.fontCascade().update(&const_cast<Document&>(document).fontSelector())
This updates the FontCascade in-place, which means that that the object shared by existing RenderStyles, and any newly created styles will be the same even when there is a change that should have prompted style diffs.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/140876951>
Simon Fraser (smfr)
Pull request: https://github.com/WebKit/WebKit/pull/37394
EWS
Committed 287326@main (c731586091b5): <https://commits.webkit.org/287326@main>
Reviewed commits have been landed. Closing PR #37394 and removing active labels.