Bug 283995

Summary: New Test (286367@main): [iOS] grid-aspect-ratio-align-items-center.html constantly failing (image).
Product: WebKit Reporter: Ben Schwartz <ben_schwartz>
Component: Layout and RenderingAssignee: Sammy Gill <sgill26>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, sgill26, simon.fraser, webkit-bot-watchers-bugzilla, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://github.com/web-platform-tests/wpt/pull/49683
Attachments:
Description Flags
masonry-intrinsic-sizing-rows-005.webarchive
none
grid-aspect-ratio-align-items-center.webarchive none

Ben Schwartz
Reported 2024-12-03 13:23:17 PST
The following 2 tests are constantly image failing on iOS: imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/grid-aspect-ratio-align-items-center.html imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/intrinsic-sizing/masonry-intrinsic-sizing-rows-005.html HISTORY: https://results.webkit.org/?suite=layout-tests&suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcss-sizing%2Faspect-ratio%2Fgrid-aspect-ratio-align-items-center.html&test=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcss-grid%2Fmasonry%2Ftentative%2Fintrinsic-sizing%2Fmasonry-intrinsic-sizing-rows-005.html&platform=ios IMAGE DIFFs: Attached as .webarchive files.
Attachments
masonry-intrinsic-sizing-rows-005.webarchive (56.92 KB, application/x-webarchive)
2024-12-03 13:23 PST, Ben Schwartz 		no flags
Details
grid-aspect-ratio-align-items-center.webarchive (56.89 KB, application/x-webarchive)
2024-12-03 13:23 PST, Ben Schwartz 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2024-12-03 13:23:27 PST
<rdar://problem/140870687>
Ben Schwartz
Comment 2 2024-12-03 13:23:29 PST
Created attachment 473448 [details] masonry-intrinsic-sizing-rows-005.webarchive
Ben Schwartz
Comment 3 2024-12-03 13:23:44 PST
Created attachment 473449 [details] grid-aspect-ratio-align-items-center.webarchive
EWS
Comment 4 2024-12-03 13:33:00 PST
Test gardening commit 287308@main (7e093430d277): <https://commits.webkit.org/287308@main> Reviewed commits have been landed. Closing PR #37390 and removing active labels.
Sammy Gill
Comment 5 2024-12-12 16:47:26 PST
grid-aspect-ratio-align-items-center.html seems to be failing because of differences with linear-gradient on iOS it seems. I should be able to fix this by slightly modifying the expected/ref masonry-intrinsic-sizing-rows-005 seems to be a completely different bug though so I'm going to create a separate bugzilla for that one
Sammy Gill
Comment 6 2024-12-12 16:55:59 PST
(Sorry I meant modifying the actual test itself not the expected/ref)
Sammy Gill
Comment 7 2024-12-12 17:45:12 PST
Pull request: https://github.com/WebKit/WebKit/pull/37878
EWS
Comment 8 2024-12-13 10:59:27 PST
Committed 287802@main (d97fff0f2eeb): <https://commits.webkit.org/287802@main> Reviewed commits have been landed. Closing PR #37878 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.