Bug 28393

Summary:

check-webkit-style: add check for use of std::max()/std::min() instead of MAX()/MIN()

Product:

WebKit

Reporter:

David Kilzer (:ddkilzer) <ddkilzer>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, levin

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch v1	levin: review+

David Kilzer (:ddkilzer)

Reported 2009-08-17 10:20:40 PDT

* SUMMARY The std::max() and std::min() template methods should be preferred over the MAX()/MIN() macros since they're typesafe and since they may be used to automatically static_cast<>() their arguments using the std::max<type>() and std::min<type>() variants. * NOTES See Bug 28355.

Attachments
Patch v1 (4.90 KB, patch) 2009-08-17 12:39 PDT, David Kilzer (:ddkilzer)	levin: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

David Kilzer (:ddkilzer)

Comment 1 2009-08-17 12:39:00 PDT

Created attachment 34986 [details] Patch v1

David Kilzer (:ddkilzer)

Comment 2 2009-08-17 13:33:44 PDT

Committed r47385: <http://trac.webkit.org/changeset/47385>

David Kilzer (:ddkilzer)

Comment 3 2009-08-17 13:33:48 PDT

All reviewed patches have been landed. Closing bug.

Adam Barth

Comment 4 2010-03-25 01:34:26 PDT

Committed r56510: <http://trac.webkit.org/changeset/56510>

Note You need to log in before you can comment on or make changes to this bug.