Bug 28393

Summary: check-webkit-style: add check for use of std::max()/std::min() instead of MAX()/MIN()
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Severity: Normal CC: abarth, levin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Description Flags
Patch v1 levin: review+

Description David Kilzer (:ddkilzer) 2009-08-17 10:20:40 PDT
The std::max() and std::min() template methods should be preferred over the MAX()/MIN() macros since they're typesafe and since they may be used to automatically static_cast<>() their arguments using the std::max<type>() and std::min<type>() variants.

See Bug 28355.
Comment 1 David Kilzer (:ddkilzer) 2009-08-17 12:39:00 PDT
Created attachment 34986 [details]
Patch v1
Comment 2 David Kilzer (:ddkilzer) 2009-08-17 13:33:44 PDT
Committed r47385: <http://trac.webkit.org/changeset/47385>
Comment 3 David Kilzer (:ddkilzer) 2009-08-17 13:33:48 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Adam Barth 2010-03-25 01:34:26 PDT
Committed r56510: <http://trac.webkit.org/changeset/56510>