Bug 283862
| Summary: | RequestAnimationFrameCallback should not be `unrestricted double` | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | Animations | Assignee: | Ahmad Saleem <ahmad.saleem792> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | graouts, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Safari Technology Preview | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ahmad Saleem
Hi Team,
While going through this file randomly I noticed that we can sync-up this bit and match with spec:
WebKit Source: https://github.com/WebKit/WebKit/blob/7071c8fbb1fec810f51c340903edd02b52161caf/Source/WebCore/dom/RequestAnimationFrameCallback.idl#L34
Web Specification: https://html.spec.whatwg.org/multipage/imagebitmap-and-animations.html#animation-frames
Current:
[ GenerateIsReachable=ImplScriptExecutionContext ] callback RequestAnimationFrameCallback = undefined (unrestricted double highResTime);
As per web specification:
[ GenerateIsReachable=ImplScriptExecutionContext ] callback RequestAnimationFrameCallback = undefined (DOMHighResTimeStamp highResTime);
where `DOMHighResTimeStamp` as per: https://w3c.github.io/hr-time/#dom-domhighrestimestamp
It is:
typedef double DOMHighResTimeStamp;
which is not `unrestricted double`.
Just raising so we can fix it.
Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/141108894>
Ahmad Saleem
Pull request: https://github.com/WebKit/WebKit/pull/46786
EWS
Committed 296745@main (cad743944a73): <https://commits.webkit.org/296745@main>
Reviewed commits have been landed. Closing PR #46786 and removing active labels.