Bug 283650

Summary:	Get Fullscreen.h out of DocumentInlines.h
Product:	WebKit	Reporter:	Simon Fraser (smfr) <simon.fraser>
Component:	DOM	Assignee:	Simon Fraser (smfr) <simon.fraser>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	simon.fraser, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Simon Fraser (smfr)

Reported 2024-11-24 09:09:29 PST

Fullscreen.h pulls in HTMLMediaElement.h which pulls in a lot of media-related headers. It doesn't seem necessary for fullscreen-related functions to be inline, so make them out-of-line so we can reduce what DocumentInlines.h pulls in.

Attachments
Add attachment proposed patch, testcase, etc.

Simon Fraser (smfr)

Comment 1 2024-11-24 09:13:59 PST

Pull request: https://github.com/WebKit/WebKit/pull/37100

Radar WebKit Bug Importer

Comment 2 2024-11-25 09:04:33 PST

<rdar://problem/140544768>

EWS

Comment 3 2024-11-25 13:03:35 PST

Committed 287070@main (a764e7f2334d): <https://commits.webkit.org/287070@main> Reviewed commits have been landed. Closing PR #37100 and removing active labels.

Note You need to log in before you can comment on or make changes to this bug.