Bug 283524

Summary:	Get FileSystem.h out of SoftLinking.h
Product:	WebKit	Reporter:	Simon Fraser (smfr) <simon.fraser>
Component:	Tools / Tests	Assignee:	Simon Fraser (smfr) <simon.fraser>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	simon.fraser, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Simon Fraser (smfr)

Reported 2024-11-21 14:26:00 PST

SoftLinking.h including FileSystem.h pulls StringCommon.h into a lot of files: 662094 ms: /Volumes/Data/Development/system/webkit/OpenSource/WebKitBuild/Debug/usr/local/include/wtf/text/StringCommon.h (included 1189 times, avg 556 ms), included via: 38x: SoftLinking.h SoftLinking.h FileSystem.h WTFString.h StringImpl.h

Attachments
Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2024-11-21 14:26:19 PST

<rdar://problem/140374614>

Simon Fraser (smfr)

Comment 2 2024-11-21 14:37:49 PST

Pull request: https://github.com/WebKit/WebKit/pull/36976

EWS

Comment 3 2024-11-23 08:16:52 PST

Committed 287011@main (82333e02424b): <https://commits.webkit.org/287011@main> Reviewed commits have been landed. Closing PR #36976 and removing active labels.

Note You need to log in before you can comment on or make changes to this bug.