Bug 283252
| Summary: | Further reduce use of WTF_ALLOW_UNSAFE_BUFFER_USAGE in WTF/ | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> |
| Component: | Web Template Framework | Assignee: | Chris Dumez <cdumez> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | cadubentzen, webkit-bug-importer, zimmermann |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Chris Dumez
Further reduce use of WTF_ALLOW_UNSAFE_BUFFER_USAGE in WTF/.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Chris Dumez
Pull request: https://github.com/WebKit/WebKit/pull/36767
EWS
Committed 286712@main (83a834b1ac4f): <https://commits.webkit.org/286712@main>
Reviewed commits have been landed. Closing PR #36767 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/140095642>
Nikolas Zimmermann
This broke compilation for me with the WPE wkdev-sdk container based build using clang 18.1.3 that is shipped with Ubuntu 24.04.
Error:
/host/home/nzimmermann/Software/GitRepositories/WebKit/Source/WTF/wtf/SHA1.cpp:111:9: error: unsafe buffer access [-Werror,-Wunsafe-buffer-usage]
111 | m_buffer[m_cursor++] = std::to_integer<uint8_t>(byte);
Apparently our clang linux post-commit bots which still use the flatpak SDK with clang 18.1.5 are fine. Still investigating.
Carlos Bentzen
I sent this patch that should fix compilation with Clang 18 in wkdev-sdk: https://github.com/WebKit/WebKit/pull/36845