Summary: | Add a test to verify that page cache can be enabled for a test | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dmitry Titov <dimich> | ||||
Component: | Tools / Tests | Assignee: | Dmitry Titov <dimich> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | ||||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Dmitry Titov
2009-08-14 15:10:49 PDT
Created attachment 34877 [details]
Proposed patch
Comment on attachment 34877 [details]
Proposed patch
Yay for trailblazing!
The test makes sense to me. I assume you've tested to make sure it fails with:
30 layoutTestController.overridePreference("WebKitUsesPageCachePreferenceKey", 1);
commented out.
I'm not sure we have a test to verify that onload would be sent twice w/ the page cache off. That seems useful to test.
Eventually we'll want to make this sort of thing into a framework, so that it's easy to test page-cache bugs. For example, we want to test what sort of things prevents a page from entering the cache. Ideally that will eventually be as easy as making a single function call in a test with a little HTML passed to it. :) But I dream...
LGTM assuming you've tested with the page cache off to make sure it fails.
Landed http://trac.webkit.org/changeset/47306 Eric, I think your points are very good. I've landed the test so it is out there and tests things, however I will think if I can create some simple 'helper script' which can make it easy to write a page cache test! |