Bug 283060
Summary: | [css-masonry] Update Intrinsic Sizing Rows 003 Mix1 Expected / Ref Test Case | ||
---|---|---|---|
Product: | WebKit | Reporter: | Brandon <brandonstewart> |
Component: | CSS | Assignee: | Brandon <brandonstewart> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | koivisto, webkit-bug-importer |
Priority: | P2 | Keywords: | InRadar |
Version: | Other | ||
Hardware: | Unspecified | ||
OS: | Unspecified |
Brandon
Use Ahem font and add colors to work around font sizing issues.
* Grid 1
Remove spans.
Add extra hidden item to correctly handle min-content size.
Add sizing for grid template columns, so the 5th item is correctly placed.
* Grid 2
Remove spans.
Add extra hidden item to correctly handle min-content size.
Add sizing for grid template columns, so the 5th item is correctly placed.
* Grid 4-5
Remove spans that were causing width issues.
* Grid 6
Remove spans that were causing width issues.
Remove extra 5 not found in the main test case.
* Grid 7 - 9
Remove spans that were causing width issues.
Remove hidden items that were adding an extra column
Add sizing for grid template columns; the grid appears to overflow without it.
Add height of 3ch to the first item, so the first row is correctly sized.
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/139810909>
Brandon
Pull request: https://github.com/WebKit/WebKit/pull/36596
EWS
Committed 286740@main (a8303551d4db): <https://commits.webkit.org/286740@main>
Reviewed commits have been landed. Closing PR #36596 and removing active labels.