|Product:||WebKit||Reporter:||Oliver Hunt <oliver>|
|Version:||528+ (Nightly build)|
|OS:||OS X 10.5|
Description Oliver Hunt 2009-08-13 22:07:52 PDT
Marking currently uses virtual methods, but in the general case these virtual calls are unnecessary and can be elided.
Comment 2 Maciej Stachowiak 2009-08-13 22:19:29 PDT
Comment on attachment 34809 [details] Patch v1 r=me but consider reformatting the long inline method definitions as suggested.
Comment 4 Gabor Loki 2009-08-18 06:07:09 PDT
Comment 5 Gabor Loki 2009-08-19 07:45:23 PDT
The bug can be reproduced on ARM with interpreter and jit as well. The situation is the same with debug and with release mode also. Does iPhone run correctly?
Comment 6 Oliver Hunt 2009-08-19 10:45:51 PDT
(In reply to comment #5) > The bug can be reproduced on ARM with interpreter and jit as well. The > situation is the same with debug and with release mode also. Does iPhone run > correctly? I just did a trivial amount of debugging myself, and forced JSVALUE_32 on x86 and this crash occurred. Given that's the only substantive difference between ARM and x86 build settings that seems obvious and demonstrates the bug.