Bug 28292 – Need to extend DumpRenderTree to expose number of worker threads

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[Andrew Wilson]

There's currently no way to track if/when worker threads actually shut down from javascript layout tests.

We need to extend DumpRenderTree to expose this information so we can write layout tests to verify this functionality.

[Andrew Wilson]

Created attachment 34806 [details]
proposed patch

Turns out adding new APIs to WebKit is trickier than it appears. We need to put together a wiki page on this.

[Andrew Wilson]

Created attachment 34808 [details]
patch with fix for gtk type error

[Eric Seidel (no email)]

Comment on attachment 34808 [details]
patch with fix for gtk type error

Wow.  I'm just blown away by how thorough this change is.  Really, wow.  I don't think I would have had the stamina to change all 4 platforms like that.

This is technically a style violation:
 32         if (layoutTestController.workerThreadCount == 1) {
 33             log("PASS: Worker thread created");
 34         } else {
 35             log("FAIL: After thread creation: layoutTestController.workerThreadCount = " + layoutTestController.workerThreadCount);
 36         }

As far as I can tell, this all looks correct.  I'm certainly no COM expert, so there could be errors there, but looks fine to me.

[Andrew Wilson]

Committed as r47429.