Summary: | Need to extend DumpRenderTree to expose number of worker threads | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andrew Wilson <atwilson> | ||||||
Component: | WebCore Misc. | Assignee: | Andrew Wilson <atwilson> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | ||||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | OS X 10.5 | ||||||||
Attachments: |
|
Description
Andrew Wilson
2009-08-13 21:00:32 PDT
Created attachment 34806 [details]
proposed patch
Turns out adding new APIs to WebKit is trickier than it appears. We need to put together a wiki page on this.
Created attachment 34808 [details]
patch with fix for gtk type error
Comment on attachment 34808 [details]
patch with fix for gtk type error
Wow. I'm just blown away by how thorough this change is. Really, wow. I don't think I would have had the stamina to change all 4 platforms like that.
This is technically a style violation:
32 if (layoutTestController.workerThreadCount == 1) {
33 log("PASS: Worker thread created");
34 } else {
35 log("FAIL: After thread creation: layoutTestController.workerThreadCount = " + layoutTestController.workerThreadCount);
36 }
As far as I can tell, this all looks correct. I'm certainly no COM expert, so there could be errors there, but looks fine to me.
|