Bug 282899
| Summary: | [RISCV] Set some used MacroAssemblerRISCV64 methods to public | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | MingZhu Yan <yanmingzhu> |
| Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Local Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
MingZhu Yan
Meet this error during compiling on my riscv64gc board.
There I only lists one error，these methods should be public.
```txt
/home/debian/repo/WebKit/Source/JavaScriptCore/bytecode/InlineCacheCompiler.cpp:2714:21: error: 'storeFloat16' is a private member of 'JSC::MacroAss
emblerRISCV64'
jit.storeFloatl6(m_scratchFPR, CCallHelpers::BaseIndex(scratch2GPR, scratchGPR, CCallHelpers::TimesTwo));
~~~~^~~~~~~~~~~~
/home/debian/repo/WebKit/Source/JavaScriptCore/assembler/MacroAssemblerRISCV64.h:4907:10: note: declared private here
void storeFloat16(FPRegisterID src, BaseIndex address)
^
```
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
MingZhu Yan
Pull request: https://github.com/WebKit/WebKit/pull/36460
EWS
Committed 286408@main (11bb72603271): <https://commits.webkit.org/286408@main>
Reviewed commits have been landed. Closing PR #36460 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/139602519>