Bug 28280

Summary: WebInspector: Evaluating objects while on a breakpoint dumps string representation instead of live object.
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: timothy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch
timothy: review-
patch timothy: review+

Description Pavel Feldman 2009-08-13 14:26:10 PDT 
1. Open Web Inspector
2. Hit Pause on Scripts Panel
3. Do something on page to execute some JS
4. In console type "window"

Expected: live expandable DOMWindow object appears in console
Actual: [object DOMWindow] appears in the console.
Comment 1 Pavel Feldman 2009-08-14 08:19:17 PDT 
Created attachment 34841 [details]
patch
Comment 2 Timothy Hatcher 2009-08-14 08:46:29 PDT 
Comment on attachment 34841 [details]
patch


> +            function(result, isException) {
> +                if (!isException)
> +                    result = JSON.parse(result);
> +                reportCompletions(result, isException);
> +            });

Can you break this out into a named function so it is easier to read? It took me a second to realize this was being passed as an argument.
Comment 3 Pavel Feldman 2009-08-14 13:39:36 PDT 
Created attachment 34870 [details]
patch

>> Can you break this out into a named function so it is easier to read? It took
>> me a second to realize this was being passed as an argument.

Done.

Thanks for review!
Comment 4 Pavel Feldman 2009-08-15 01:59:36 PDT 
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/inspector/front-end/ConsoleView.js
	M	WebCore/inspector/front-end/ScriptsPanel.js
Committed r47318