Bug 28280 – WebInspector: Evaluating objects while on a breakpoint dumps string representation instead of live object.

• Component: Web Inspector (Deprecated)
• Status: RESOLVED FIXED

[Pavel Feldman]

1. Open Web Inspector
2. Hit Pause on Scripts Panel
3. Do something on page to execute some JS
4. In console type "window"

Expected: live expandable DOMWindow object appears in console
Actual: [object DOMWindow] appears in the console.

[Pavel Feldman]

Created attachment 34841 [details]
patch

[Timothy Hatcher]

Comment on attachment 34841 [details]
patch


> +            function(result, isException) {
> +                if (!isException)
> +                    result = JSON.parse(result);
> +                reportCompletions(result, isException);
> +            });

Can you break this out into a named function so it is easier to read? It took me a second to realize this was being passed as an argument.

[Pavel Feldman]

Created attachment 34870 [details]
patch

>> Can you break this out into a named function so it is easier to read? It took
>> me a second to realize this was being passed as an argument.

Done.

Thanks for review!

[Pavel Feldman]

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/inspector/front-end/ConsoleView.js
	M	WebCore/inspector/front-end/ScriptsPanel.js
Committed r47318