Bug 282745
Summary: | [RISCV] no viable conversion from 'TempRegister<(TempRegisterType)'\x00'>' to 'RegisterID' | ||
---|---|---|---|
Product: | WebKit | Reporter: | MingZhu Yan <yanmingzhu> |
Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | webkit-bug-importer |
Priority: | P2 | Keywords: | InRadar |
Version: | WebKit Local Build | ||
Hardware: | Unspecified | ||
OS: | Unspecified |
MingZhu Yan
Here is the error I encountered while compiling on sipeed licheepi4a (a riscv64gc board)
1:
```txt
/home/debian/repo/WiebKit/Source/JavasoriptCore/assenbler/MacroAssenberRISCV64.h:662:36: error: no viable conversion from 'TempRegister<(TempRegisterType)'\x00'>' to 'RegisterID' (aka 'JSC::RISCVĂ©64Registers::RegisterID')
m_assembler.sllwInsn(dest, temp, shiftAmount);
```
2:
```txt
In file included from /home/debian/repo/WebKit/Source/JavaScriptCore/jit/GPRInfo.h:28:
In file included from /home/debian/repo/WebKit/Source/JavaScriptCore/assembler/MacroAssembler.h:81:
/home/debian/repo/WebKit/Source/JavaScriptCore/assembler/MacroAssemblerRISCV64.h:661:9: error: no matching member function for call to 'move'
move (imm, temp);
```
I think we should call TempRegister.data() here
```txt
template<TempRegisterType... RegisterTypes>
struct TempRegister {
RegisterID data()
{
static_assert(((RegisterTypes == Data) || ...));
return dataTempRegister;
}
```
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
MingZhu Yan
Pull request: https://github.com/WebKit/WebKit/pull/36377
Radar WebKit Bug Importer
<rdar://problem/139860945>
EWS
Committed 286593@main (47fe98fc3982): <https://commits.webkit.org/286593@main>
Reviewed commits have been landed. Closing PR #36377 and removing active labels.