Summary: | [QT] revert the temporary S60 RVCT elftran workaround in qwebview.h when the right symbol is exported from Qt lib. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yongjun Zhang <yongjun.zhang> | ||||
Component: | WebKit Qt | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Minor | CC: | commit-queue, hausmann, koshuin, laszlo.gombos, norbert.leser, webkit.review.bot | ||||
Priority: | P2 | Keywords: | Qt | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | S60 Hardware | ||||||
OS: | S60 3rd edition | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 27065 | ||||||
Attachments: |
|
Description
Yongjun Zhang
2009-08-13 12:23:08 PDT
Is this fix in Qt 4.6 now ? Is it time to revert ? (In reply to comment #1) > Is this fix in Qt 4.6 now ? Is it time to revert ? Yes, it's fixed in Qt 4.6 and the fix is part of Qt 4.6.0: http://qt.gitorious.org/qt/qt/commit/8d0b487437e731ff3f5f97779002a4ffb48d92ec Unfortunately we missed this revert in WebKit for 4.6.0, but we should still do it in the trunk of course :) Created attachment 44746 [details]
Patch
style-queue ran check-webkit-style on attachment 44746 [details] without any errors.
Comment on attachment 44746 [details] Patch Clearing flags on attachment: 44746 Committed r52065: <http://trac.webkit.org/changeset/52065> All reviewed patches have been landed. Closing bug. I was talking rubbish: Of course we can include this in 4.6.x, as it doesn not affect the number of exported symbols at all. Cherry-picked as commit 488a95f395a49bdd781d878891b45c61b450404a |