Bug 282686
| Summary: | [WPE] media/media-video-fullrange.html is a permanent failure | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Jean-Yves Avenard [:jya] <jean-yves.avenard> |
| Component: | Media | Assignee: | Diego Pino <dpino> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | philn, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Jean-Yves Avenard [:jya]
In bug 267400 a test for vp8/vp9 test was added checking that the full range flag is properly recognized.
It's a permanent failure on WPE
```
--- /home/ews/worker/WPE-WK2-Tests-EWS/build/layout-test-results/media/media-video-fullrange-expected.txt
+++ /home/ews/worker/WPE-WK2-Tests-EWS/build/layout-test-results/media/media-video-fullrange-actual.txt
@@ -4,31 +4,31 @@
EXPECTED (pixelData[1] >= '12'), OBSERVED '0' FAIL
EXPECTED (pixelData[2] >= '12'), OBSERVED '0' FAIL
EVENT(loadedmetadata)
-EXPECTED (pixelData[0] >= '12') OK
-EXPECTED (pixelData[1] >= '12') OK
-EXPECTED (pixelData[2] >= '12') OK
-EVENT(loadedmetadata)
-EXPECTED (pixelData[0] >= '12') OK
-EXPECTED (pixelData[1] >= '12') OK
-EXPECTED (pixelData[2] >= '12') OK
-EVENT(loadedmetadata)
-EXPECTED (pixelData[0] >= '12') OK
-EXPECTED (pixelData[1] >= '12') OK
-EXPECTED (pixelData[2] >= '12') OK
+EXPECTED (pixelData[0] >= '12'), OBSERVED '0' FAIL
+EXPECTED (pixelData[1] >= '12'), OBSERVED '0' FAIL
+EXPECTED (pixelData[2] >= '12'), OBSERVED '0' FAIL
EVENT(loadedmetadata)
EXPECTED (pixelData[0] >= '12'), OBSERVED '0' FAIL
EXPECTED (pixelData[1] >= '12'), OBSERVED '0' FAIL
EXPECTED (pixelData[2] >= '12'), OBSERVED '0' FAIL
EVENT(loadedmetadata)
-EXPECTED (pixelData[0] >= '12') OK
-EXPECTED (pixelData[1] >= '12') OK
-EXPECTED (pixelData[2] >= '12') OK
+EXPECTED (pixelData[0] >= '12'), OBSERVED '0' FAIL
+EXPECTED (pixelData[1] >= '12'), OBSERVED '0' FAIL
+EXPECTED (pixelData[2] >= '12'), OBSERVED '0' FAIL
EVENT(loadedmetadata)
-EXPECTED (pixelData[0] >= '12') OK
-EXPECTED (pixelData[1] >= '12') OK
-EXPECTED (pixelData[2] >= '12') OK
+EXPECTED (pixelData[0] >= '12'), OBSERVED '0' FAIL
+EXPECTED (pixelData[1] >= '12'), OBSERVED '0' FAIL
+EXPECTED (pixelData[2] >= '12'), OBSERVED '0' FAIL
EVENT(loadedmetadata)
-EXPECTED (pixelData[0] >= '12') OK
-EXPECTED (pixelData[1] >= '12') OK
-EXPECTED (pixelData[2] >= '12') OK
+EXPECTED (pixelData[0] >= '12'), OBSERVED '0' FAIL
+EXPECTED (pixelData[1] >= '12'), OBSERVED '0' FAIL
+EXPECTED (pixelData[2] >= '12'), OBSERVED '0' FAIL
+EVENT(loadedmetadata)
+EXPECTED (pixelData[0] >= '12'), OBSERVED '0' FAIL
+EXPECTED (pixelData[1] >= '12'), OBSERVED '0' FAIL
+EXPECTED (pixelData[2] >= '12'), OBSERVED '0' FAIL
+EVENT(loadedmetadata)
+EXPECTED (pixelData[0] >= '12'), OBSERVED '0' FAIL
+EXPECTED (pixelData[1] >= '12'), OBSERVED '0' FAIL
+EXPECTED (pixelData[2] >= '12'), OBSERVED '0' FAIL
```
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Philippe Normand
This is working in GTK. Maybe the colorspace is not handled correctly in the WPE canvas implementation...
Diego Pino
Pull request: https://github.com/webkit/webkit/pull/37021
Diego Pino
Pull request: https://github.com/webkit/webkit/pull/37375
EWS
Committed 287790@main (ddd2e19a9ec5): <https://commits.webkit.org/287790@main>
Reviewed commits have been landed. Closing PR #37021 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/141432962>
Philippe Normand
Re-opening until https://github.com/WebKit/WebKit/pull/37021#issuecomment-2541518638 is answered.
Diego Pino
(In reply to Philippe Normand from comment #6)
> Re-opening until
> https://github.com/WebKit/WebKit/pull/37021#issuecomment-2541518638 is
> answered.
Initially I thought the change would fix this test, but it doesn't. This bug should remain open (I should have filed a new bug instead).
Diego Pino
This test is consistently passing now:
- https://results.webkit.org/?platform=GTK&platform=WPE&suite=layout-tests&test=media/media-video-fullrange.html&
The test started passing in the interval: 292060@main..292066@main. Commit 292066@main seems related but that commit only adds a new test. The commit that replaces 'PLATFORM(MEDIA_STREAM)' for 'ENABLE(MEDIA_STREAM)', mentioned in 292066@main, it is actually 291923@main.
Test removed from test expectations in 295817@main. Closing bug.