Bug 28265 – Fix off-by-one result comparisons in media tests on Windows Debug builds

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Adam Roben (:aroben)]

Created attachment 34755 [details]
Patch v1

media/video-played.html seems always to time out in Windows Debug
builds. A race condition between media/video-test.js's "hang" timer and
DumpRenderTree's built-in "watchdog" timer was causing results for
media/video-played.html to be printed twice, causing all future media
tests to be compared to the previous test's results.

The fix is to get rid of video-test.js's hang timer, since it is
redundant given the existence of DRT's watchdog timer.

Reviewed by NOBODY (OOPS!).

Need a short description and bug URL (OOPS!)

* media/video-test.js: Remove the hang timer, since DRT does the same
thing.
---
 2 files changed, 21 insertions(+), 8 deletions(-)

[Mark Rowe (bdash)]

Comment on attachment 34755 [details]
Patch v1

Is the result being printed twice a bug in DRT?  How does that happen?

[Adam Roben (:aroben)]

Created attachment 34758 [details]
Do a better fix inside DRT

[Adam Roben (:aroben)]

(In reply to comment #1)
> (From update of attachment 34755 [details])
> Is the result being printed twice a bug in DRT?  How does that happen?

You're right, there is a bug in DRT. I've attached a new patch that fixes it.

[Mark Rowe (bdash)]

Comment on attachment 34758 [details]
Do a better fix inside DRT

r=me

[Adam Roben (:aroben)]

Comment on attachment 34758 [details]
Do a better fix inside DRT

Landed as r47213. http://trac.webkit.org/changeset/47213

[Adam Roben (:aroben)]

Comment on attachment 34755 [details]
Patch v1

Landed as r47214. http://trac.webkit.org/changeset/47214