Bug 282596
| Summary: | [Windows] Bundle WebKit.resources folder | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Max Schmitt <max> |
| Component: | Platform | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | Hironori.Fujii, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Safari Technology Preview | ||
| Hardware: | Other | ||
| OS: | Windows 11 | ||
Max Schmitt
Currently the Minibrowser on Windows ships a WebKit.resources directory while other platforms bundle it.
The directory consists of 1273 files and 19 MB in total. Bundling would make distribution easier, since esp. file writes are slow on Windows.
Probably Resource Files should be used in order to replace these:
https://github.com/WebKit/WebKit/blob/460abf576622806c66767e3ac5c9f01ee912070e/Source/WebCore/platform/win/WebCoreBundleWin.cpp#L49-L73
and align them with GTK/WPE which is using g_resources_lookup_data:
https://github.com/search?q=repo%3AWebKit%2FWebKit+g_resources_lookup_data+&type=code
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Fujii Hironori
Windows resource file doesn't have a concept of path, but resource ID.
I think zip (compressed or uncompressed) or a custom resource file based on SQLite would be better.
https://www.sqlite.org/fasterthanfs.html
Fujii Hironori
https://www.sqlite.org/sqlar.html
Radar WebKit Bug Importer
<rdar://problem/139713820>