Bug 28252

Summary:

[Haiku] Adding the lack of JPEG support to ImageSource.cpp.

Product:

WebKit

Reporter:

Maxime Simon <simon.maxime>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED WONTFIX

Severity:

Normal

CC:

leavengood, pkasting

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Other

Attachments:

Description	Flags
Adding the lack of JPEG support to ImageSource.cpp.	eric: review-
Adding the lack of JPEG support to ImageSource.cpp	none
Adding the lack of JPEG support to ImageSource.cpp	none

Maxime Simon

Reported 2009-08-13 03:19:12 PDT

For the moment the Haiku port doesn't support JPEG (there is no libjpeg in the default system). Here are some modifications in ImageSource.cpp to consider this. Regards, Maxime

Attachments
Adding the lack of JPEG support to ImageSource.cpp. (2.72 KB, patch) 2009-08-13 04:12 PDT, Maxime Simon	eric: review-	Details Formatted Diff Diff
Adding the lack of JPEG support to ImageSource.cpp (2.76 KB, patch) 2009-08-13 11:47 PDT, Maxime Simon	no flags	Details Formatted Diff Diff
Adding the lack of JPEG support to ImageSource.cpp (2.80 KB, patch) 2009-08-13 11:49 PDT, Maxime Simon	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Maxime Simon

Comment 1 2009-08-13 04:12:43 PDT

Created attachment 34728 [details] Adding the lack of JPEG support to ImageSource.cpp.

Eric Seidel (no email)

Comment 2 2009-08-13 09:54:30 PDT

Comment on attachment 34728 [details] Adding the lack of JPEG support to ImageSource.cpp. What are the style changes from? check-webkit-style? I'd have to check the guide to see if those are correct or not, I can never remember for multi-line operations.

Maxime Simon

Comment 3 2009-08-13 09:59:15 PDT

(In reply to comment #2) > (From update of attachment 34728 [details]) > What are the style changes from? check-webkit-style? I'd have to check the > guide to see if those are correct or not, I can never remember for multi-line > operations. From the guideline: - never compare to 0. - in a condition && and || should be put on the begin of the line. check-webkit-style complained with ImageSourceHaiku for these things, so I supposed it the same for this file. :) Regards, Maxime

Peter Kasting

Comment 4 2009-08-13 10:30:28 PDT

I'm fine with the style changes, I think they're correct. Only suggestion I'd make is to put in a comment about why you're not supporting JPEG for Haiku: #if !PLATFFORM(HAIKU) // Haiku doesn't ship libjpeg right now. Looks fine to me otherwise if Eric wants to r+.

Eric Seidel (no email)

Comment 5 2009-08-13 11:44:09 PDT

Comment on attachment 34728 [details] Adding the lack of JPEG support to ImageSource.cpp. Great! Please add the comment as peter suggested and post the revised patch for me (or anyone else) to r+. Looks good though.

Maxime Simon

Comment 6 2009-08-13 11:47:57 PDT

Created attachment 34762 [details] Adding the lack of JPEG support to ImageSource.cpp

Maxime Simon

Comment 7 2009-08-13 11:49:02 PDT

Created attachment 34763 [details] Adding the lack of JPEG support to ImageSource.cpp

Maxime Simon

Comment 8 2009-08-16 09:36:38 PDT

Comment on attachment 34763 [details] Adding the lack of JPEG support to ImageSource.cpp I mark this one as obsolete, because the Haiku is working on integrating libjpeg natively.

Peter Kasting

Comment 9 2009-08-28 10:40:18 PDT

I interpret comment 8 as saying we should go ahead and close this.

Ryan Leavengood

Comment 10 2009-08-28 10:55:07 PDT

(In reply to comment #9) > I interpret comment 8 as saying we should go ahead and close this. Yes sir, the closing of this is fine. I found it quite silly for Haiku to not have libjpeg exposed so I rectified that problem :)

Note You need to log in before you can comment on or make changes to this bug.