Bug 282509
| Summary: | [WTF] BoundsCheckedIterator wants begin()/end() functions for ASCIILiteral, CString, StringTypeAdapter<>, HashTranslatorCharBuffer<> | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> |
| Component: | Web Template Framework | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | CC: | ggaren, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Other | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 282493 | ||
| Bug Blocks: | |||
David Kilzer (:ddkilzer)
WTF::BoundsCheckedIterator needs begin()/end() functions for WTF::ASCIILiteral, WTF::CString, WTF::StringTypeAdapter<>, WTF::HashTranslatorCharBuffer<>.
Commit 286059@main for Bug 282493 broke the build for upstream clang:
```
/usr/local/include/wtf/IndexedRange.h:76:66: error: no member named 'begin' in 'WTF::ASCIILiteral'
76 | return BoundsCheckedIterator<Collection, decltype(collection.begin())>::begin(collection);
| ~~~~~~~~~~ ^
/usr/local/include/wtf/IndexedRange.h:76:66: error: no member named 'begin' in 'WTF::CString'
76 | return BoundsCheckedIterator<Collection, decltype(collection.begin())>::begin(collection);
| ~~~~~~~~~~ ^
/usr/local/include/wtf/IndexedRange.h:76:66: error: no member named 'begin' in 'WTF::StringTypeAdapter<std::span<const unsigned char>>'
76 | return BoundsCheckedIterator<Collection, decltype(collection.begin())>::begin(collection);
| ~~~~~~~~~~ ^
/usr/local/include/wtf/IndexedRange.h:76:66: error: no member named 'begin' in 'WTF::HashTranslatorCharBuffer<unsigned char>'
76 | return BoundsCheckedIterator<Collection, decltype(collection.begin())>::begin(collection);
| ~~~~~~~~~~ ^
/usr/local/include/wtf/IndexedRange.h:76:66: error: no member named 'begin' in 'WTF::HashTranslatorCharBuffer<char16_t>'
76 | return BoundsCheckedIterator<Collection, decltype(collection.begin())>::begin(collection);
| ~~~~~~~~~~ ^
```
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/139160864>
David Kilzer (:ddkilzer)
Dupe: Bug 282513
*** This bug has been marked as a duplicate of bug 282513 ***