Bug 282474

Summary:	Timer should hold a CheckedRef to the object before calling the timeout function on it, when possible
Product:	WebKit	Reporter:	Chris Dumez <cdumez>
Component:	WebCore Misc.	Assignee:	Chris Dumez <cdumez>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	darin, ggaren, Hironori.Fujii, rniwa, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
See Also:	https://bugs.webkit.org/show_bug.cgi?id=282421 https://bugs.webkit.org/show_bug.cgi?id=282559

Chris Dumez

Reported 2024-11-01 16:24:27 PDT

Timer should hold a CheckedRef to the object before calling the timeout function on it, when possible. We use a RefPtr if the class if ref-counted, otherwise we fallback to using a CheckedRef if the class subclasses CanMakeCheckedPtr, otherwise, we fallback to legacy behavior.

Attachments
Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2024-11-01 16:45:59 PDT

Pull request: https://github.com/WebKit/WebKit/pull/36077

EWS

Comment 2 2024-11-04 07:26:15 PST

Committed 286084@main (4917f5eb6c87): <https://commits.webkit.org/286084@main> Reviewed commits have been landed. Closing PR #36077 and removing active labels.

Radar WebKit Bug Importer

Comment 3 2024-11-04 07:27:15 PST

<rdar://problem/139201809>

Note You need to log in before you can comment on or make changes to this bug.