Bug 282421
| Summary: | Have Timer protect the object it is calling the timeout function on when possible | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> |
| Component: | Platform | Assignee: | Chris Dumez <cdumez> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | darin, ggaren, rniwa, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=282439 https://bugs.webkit.org/show_bug.cgi?id=282474 |
||
Chris Dumez
Have Timer protect the object it is calling the timeout function on when possible. Otherwise, people have to remember to add a `protectedThis` protector at the beginning out of `timerFired()` functions, which is error prone.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Chris Dumez
I have it working. Will upload shortly.
Chris Dumez
Pull request: https://github.com/WebKit/WebKit/pull/36033
EWS
Committed 286015@main (e6d75cd60444): <https://commits.webkit.org/286015@main>
Reviewed commits have been landed. Closing PR #36033 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/139084103>