Bug 28232

Summary: "Null after navigation" in major-objects.html is unclear
Product: WebKit Reporter: Joe Mason <joenotcharles>
Component: WebKit WebsiteAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Enhancement CC: abarth
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch to html file none

Joe Mason
Reported 2009-08-12 14:33:18 PDT
Adam Barth explains the "null after navigation" comment in major-objects.html like this: > > "NULL after navigation" could be clearer - it suggests that DOMWindow and > > everything below it only exists if you type the URL, but not if a page is > > loaded by clicking a link, which can't be true. > > Oh, I meant navigate to cover both typing in the location bar and > clicking a link. Is there a better word to use for that? > > > Does it mean that it's NULL > > immediately after navigation, while waiting for the load, and is replaced by > > a valid pointer after loading? > > I wasn't sure the best way to represent this in the diagram. > Typically, the edge becomes null in the "up" direction and replaced > with a new object in the "down" direction. If you can think of a nice > way to explain this on the page, please file a bug, CC me, and upload > a patch. I think the best way to represent this is with a footnoted explanation. (Patch forthcoming)
Attachments
patch to html file (1.95 KB, patch)
2009-08-12 14:38 PDT, Joe Mason
no flags
Joe Mason
Comment 1 2009-08-12 14:38:49 PDT
Created attachment 34693 [details] patch to html file
Adam Barth
Comment 2 2009-08-12 20:01:24 PDT
Comment on attachment 34693 [details] patch to html file Excellent!
Adam Barth
Comment 3 2009-08-12 22:00:54 PDT
Comment on attachment 34693 [details] patch to html file Clearing flags on attachment: 34693 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKitSite/ChangeLog M WebKitSite/coding/major-objects.html Committed r47182 M WebKitSite/ChangeLog M WebKitSite/coding/major-objects.html r47182 = 9f401117450f829c83ec4f0940e4918f455e7d31 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/47182
Adam Barth
Comment 4 2009-08-12 22:01:06 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.