Bug 282265
| Summary: | [webkitpy][WTR] Allow passing all environment variables that start with specific prefixes like 'WEBKIT' | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Carlos Alberto Lopez Perez <clopez> |
| Component: | Tools / Tests | Assignee: | Carlos Alberto Lopez Perez <clopez> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bugs-noreply, csaavedra, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Carlos Alberto Lopez Perez
On the webkitpy WTR runner we clean the user environment and we only allow to pass to WTR a closed list of environment variables.
The issue is that we keep adding env vars with prefixes like WEBKIT_SOMETHING and is hard to keep track off all of them.
So instead of listing all this variables, just allow to pass any that start with a specific prefix
Examples of variables that are useful to pass and that we are not currently allowing:
WEBKIT2_PAUSE_WEB_PROCESS_ON_LAUNCH
WEBKIT_DISABLE_MEMORY_PRESSURE_MONITOR
WEBKIT_A11Y_BUS_ADDRESS
WEBKIT_CAIRO_PAINTING_THREADS
WEBKIT_DISABLE_ASYNC_SCROLLING
WEBKIT_DISABLE_COMPOSITING_MODE
WEBKIT_DISABLE_DMABUF_RENDERER
WEBKIT_DISABLE_MEMORY_ATTRIBUTION
WEBKIT_DISABLE_SANDBOX_THIS_IS_DANGEROUS
WEBKIT_DMABUF_RENDERER_BUFFER_FORMAT
WEBKIT_DMABUF_RENDERER_DISABLE_GBM
WEBKIT_DMABUF_RENDERER_FORCE_SHM
WEBKIT_EGL_PIXEL_LAYOUT
WEBKIT_ENABLE_A11Y_DBUS_PROXY_LOGGING
WEBKIT_ENABLE_DBUS_PROXY_LOGGING
WEBKIT_ENABLE_DEBUG_PERMISSIONS_IN_SANDBOX
WEBKIT_FORCE_COMPLEX_TEXT
WEBKIT_FORCE_COMPOSITING_MODE
WEBKIT_FORCE_SANDBOX
WEBKIT_FORCE_VBLANK_TIMER
WEBKIT_GST_CUSTOM_VIDEO_SINK
WEBKIT_GST_DISABLE_FAST_MALLOC
WEBKIT_GST_DMABUF_FORMATS
WEBKIT_GST_ENABLE_AUDIO_MIXER
WEBKIT_GST_ENABLE_DASH_SUPPORT
WEBKIT_GST_ENABLE_HLS_SUPPORT
WEBKIT_GST_ENABLE_LEGACY_VAAPI
WEBKIT_GST_MAX_AVC1_RESOLUTION
WEBKIT_INSPECTOR_HTTP_SERVER
WEBKIT_INSPECTOR_RESOURCES_PATH
WEBKIT_INSPECTOR_SERVER
WEBKIT_LOG_INCOMING_MESSAGES
WEBKIT_MESSAGE_TEST_DEFAULT_DRIVER
WEBKIT_SAMPLE_MEMORY
WEBKIT_SHOW_COMPOSITING_DEBUG_VISUALS
WEBKIT_SHOW_FPS
WEBKIT_SKIA_ENABLE_CPU_RENDERING
WEBKIT_SKIA_MSAA_SAMPLE_COUNT
WEBKIT_SKIA_PAINTING_THREADS
WEBKIT_TLS_CAFILE_PEM
WEBKIT_UNSET_DYLD_FRAMEWORK_PATH
WEBKIT_USE_PORTAL
WEBKIT_WEBGL_DISABLE_GBM
WEBKIT_WEB_RENDER_DEVICE_FILE
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Carlos Alberto Lopez Perez
Pull request: https://github.com/WebKit/WebKit/pull/35886
Radar WebKit Bug Importer
<rdar://problem/139299872>
EWS
Committed 286430@main (3bae70608191): <https://commits.webkit.org/286430@main>
Reviewed commits have been landed. Closing PR #35886 and removing active labels.