Bug 28222 – bugzilla-tool needs a way to ask build.webkit.org if the bots are passing

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Eric Seidel (no email)]

bugzilla-tool needs a way to ask build.webkit.org if the bots are passing

If they're not passing we should not run the --commit-queue, etc.

I'd rather not scrape the buildbot page, but we could.  I don't want to put too much extra load on the buildbot master.

[Eric Seidel (no email)]

I have a patch which I'm testing now.  Will attach for others to see.

[Eric Seidel (no email)]

Created attachment 34999 [details]
Patch v1

[Eric Seidel (no email)]

Created attachment 35000 [details]
Updated patch which actually passed the unit tests

[Eric Seidel (no email)]

I don't know much about buildbot's xmlrpc (or xmlrpc in general).  It might be possible to do all this and more via a few xmlrpc calls:
http://buildbot.net/apidocs/buildbot.status.web.xmlrpc.XMLRPCServer-class.html

[Adam Barth]

This patch doesn't seem to call ensure_builders_are_green.  Did you mean to call that during land-diff and land-patches?

[Eric Seidel (no email)]

Yes. :)  Will fix.

[Eric Seidel (no email)]

Yay!  It's working!

Sleeping.... Mon Aug 17 22:33:06 PDT 2009
Fetching http://build.webkit.org/one_box_per_builder
ERROR: Builders at build.webkit.org are red, please do not commit.  Pass --ignore-builders to bypass this check.
Fetching http://build.webkit.org/one_box_per_builder
ERROR: Builders at build.webkit.org are red, please do not commit.  Pass --ignore-builders to bypass this check.
Sleeping.... Mon Aug 17 22:43:09 PDT 2009

[Eric Seidel (no email)]

(The windows buildbots are currently red, thus the commit-queue is correctly pausing itself until they roll green again.  It wakes up every 10 minutes to check.)

[Mark Rowe (bdash)]

Comment on attachment 35000 [details]
Updated patch which actually passed the unit tests

 47         # Other builders should be added to this list once they're known to be stable.
 48         self.core_builder_names_regexps = [ 'Leopard', "Windows.*Build" ]

Why is Tiger being left off?

[Eric Seidel (no email)]

I just picked the bots which seemed the most consistent. If you'd like, I can add Tiger there too.  It seems that tiger breaks rather often, and we don't bother to "close" the tree when it does.  When Leopard or the Windows build breaks we seem to have fire-drills.  I wasn't really trying to make policy with this change, so much as teach the commit-queue about our existing policy.  I'm also happy to make the commit-queue block on all bots being green, but that's probably extreme.

[Eric Seidel (no email)]

Created attachment 35159 [details]
Patch v1

[Adam Barth]

Comment on attachment 35159 [details]
Patch v1

Great!  Mark, we can iterate on the list of builders if this list isn't sufficient.

[Eric Seidel (no email)]

Committed r47532: <http://trac.webkit.org/changeset/47532>