Bug 28215

Summary: [v8] Fix atomic string externalization crash
Product: WebKit Reporter: Christian Plesner Hansen <christian.plesner.hansen>
Component: WebCore Misc.Assignee: Christian Plesner Hansen <christian.plesner.hansen>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, eric, levin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
"Initial"
none
Tabs-fix dglazkov: review+, eric: commit-queue-

Description Christian Plesner Hansen 2009-08-12 02:38:10 PDT 
Atomic string externalization assumes that all non-empty strings can be externalized which is untrue on 64-bit.  This change fixed that.
Comment 1 Christian Plesner Hansen 2009-08-12 02:39:55 PDT 
Created attachment 34649 [details]
"Initial"
Comment 2 Christian Plesner Hansen 2009-08-12 04:15:00 PDT 
Created attachment 34652 [details]
Tabs-fix
Comment 3 Dimitri Glazkov (Google) 2009-08-12 08:48:13 PDT 
Comment on attachment 34652 [details]
Tabs-fix

r=me
Comment 4 Dimitri Glazkov (Google) 2009-08-12 08:54:08 PDT 
Landed as http://trac.webkit.org/changeset/47106.
Comment 5 David Levin 2009-08-12 15:11:42 PDT 
Had to roll this out http://trac.webkit.org/changeset/47153 due to v8 being rolled back upstream.
Comment 6 David Levin 2009-08-12 15:12:47 PDT 
Comment on attachment 34652 [details]
Tabs-fix

This commit needs to wait for an appropriate version of v8 to be available downstream.
Comment 7 David Levin 2009-08-13 11:26:56 PDT 
Comment on attachment 34652 [details]
Tabs-fix

The v8 build with the api has landed upstream so this can be committed now.
Comment 8 Eric Seidel (no email) 2009-08-13 11:52:19 PDT 
Comment on attachment 34652 [details]
Tabs-fix

Rejecting patch 34652 from commit-queue.  This patch will require manual commit.

Failed to run "['git', 'svn', 'dcommit']"  exit_code: 1  cwd: None
Comment 9 Eric Seidel (no email) 2009-08-13 11:55:04 PDT 
    The following files contain tab characters:

        trunk/WebCore/ChangeLog

    Please use spaces instead to indent.
    If you must commit a file with tabs, use svn propset to set the "allow-tabs" property.

Will need to be fixed manually.  We need to make svn-create-patch warn about this type of error to catch these things earlier.
Comment 10 Christian Plesner Hansen 2009-08-13 12:18:50 PDT 
>     The following files contain tab characters:
> 
>         trunk/WebCore/ChangeLog

I don't see any tabs in the updated patch.
Comment 11 Eric Seidel (no email) 2009-08-13 13:15:35 PDT 
vim shows a ^I char here:
+        [v8] Fix atomic string externalization crash.^I$
Comment 12 Eric Seidel (no email) 2009-08-13 13:16:25 PDT 
I'll land this manually.
Comment 13 Eric Seidel (no email) 2009-08-13 13:17:10 PDT 
Comment on attachment 34652 [details]
Tabs-fix

Rejecting patch 34652 from commit-queue.  This patch will require manual commit.

Failed to run "['git', 'svn', 'dcommit']"  exit_code: 1  cwd: None
Comment 14 Eric Seidel (no email) 2009-08-13 13:18:10 PDT 
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/bindings/v8/V8Binding.cpp
Committed r47227
	M	WebCore/ChangeLog
	M	WebCore/bindings/v8/V8Binding.cpp
r47227 = a210e42b217c8c1eff26cbd44431379c0e2fde0b (trunk)
No changes between current HEAD and refs/remotes/trunk
Resetting to the latest refs/remotes/trunk
http://trac.webkit.org/changeset/47227