Bug 282069
| Summary: | [Observable] Code should not use AbortController directly, and instead use the internal AbortSignal API | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Marais Rossouw <me> |
| Component: | DOM | Assignee: | Marais Rossouw <me> |
| Status: | RESOLVED FIXED | ||
| Severity: | Trivial | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Marais Rossouw
It appears that the Observables code (InternalObserver*.cpp, Subscriber.cpp, Observable.cpp, et al) is the only code in the WebKit that internally uses the AbortController to the pluck the signal.
We should be using the AbortSignal directly, its slightly faster, less allocations, and more consistent.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Marais Rossouw
Pull request: https://github.com/WebKit/WebKit/pull/35711
EWS
Committed 285723@main (39636bf8cda7): <https://commits.webkit.org/285723@main>
Reviewed commits have been landed. Closing PR #35711 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/138675088>