Summary: | [Chromium] drop down menu letter selection, skip selections | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Xiaomei Ji <xji> | ||||
Component: | WebKit Misc. | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | eric, hbono, xji | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | Windows XP | ||||||
URL: | http://www.njtransit.com/sf/sf_servlet.srv?hdnPageAction=TrainSchedulesTo | ||||||
Attachments: |
|
Description
Xiaomei Ji
2009-08-11 17:54:49 PDT
Created attachment 34631 [details]
patch w/ manual test
Comment on attachment 34631 [details]
patch w/ manual test
OK.
Comment on attachment 34631 [details]
patch w/ manual test
Rejecting patch 34631 from commit-queue. This patch will require manual commit.
WebKitTools/Scripts/run-webkit-tests --no-launch-safari --quiet failed with exit code 1
Comment on attachment 34631 [details]
patch w/ manual test
The failure was:
Testing 11049 test cases.
fast/js/global-constructors.html -> failed
Which should be unrelated. I expect the bots just went red and I didn't notice.
(In reply to comment #4) > (From update of attachment 34631 [details]) > The failure was: > Testing 11049 test cases. > fast/js/global-constructors.html -> failed > > Which should be unrelated. I expect the bots just went red and I didn't > notice. you probably right. There is no such failure in my local run with my change. Comment on attachment 34631 [details] patch w/ manual test Clearing flags on attachment: 34631 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog A WebCore/manual-tests/keyboard_select_elements_with_same_beginning.html M WebCore/platform/chromium/PopupMenuChromium.cpp Committed r47150 M WebCore/ChangeLog M WebCore/platform/chromium/PopupMenuChromium.cpp A WebCore/manual-tests/keyboard_select_elements_with_same_beginning.html r47150 = bc763ed3dfd04ac8690009160a8baa8af4d3053e (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/47150 All reviewed patches have been landed. Closing bug. |