Summary: | Not possible to build WebCore+V8 with -fno-exceptions on Mac | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mark Mentovai <mark> | ||||||||
Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | abarth, eric | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Mac | ||||||||||
OS: | OS X 10.5 | ||||||||||
Attachments: |
|
Description
Mark Mentovai
2009-08-11 17:52:02 PDT
Created attachment 34623 [details]
Only undefine |try| and |catch| when building Objective-C[++]
Comment on attachment 34623 [details] Only undefine |try| and |catch| when building Objective-C[++] > +/* When C++ exceptions are disabled, the C++ STL defines |try| and |catch| to > + * allow C++ code that expects exceptions to build. These definitions We use one space after a period, not two. It would be nice to have your comment follow that rule. I think the use of the term STL in this comment is a little dated. That's really not the name for it any more. This is definitely a bug in the C++ library, but one that the folks who maintain it have declined to fix. Created attachment 34626 [details]
Comments updated
Created attachment 34627 [details]
Fix "Reviewed by".
Comment on attachment 34627 [details]
Fix "Reviewed by".
Rejecting patch 34627 from commit-queue. This patch will require manual commit.
WebKitTools/Scripts/run-webkit-tests --no-launch-safari --quiet failed with exit code 1
Comment on attachment 34627 [details]
Fix "Reviewed by".
fast/layers/video-layer.html -> failed
media/audio-delete-while-step-button-clicked.html -> failed
media/video-controls-transformed.html -> failed
media/video-controls-zoomed.html -> failed
Test failures caused this regression. I don't think they were caused by this patch. Adding back to commit queue.
Comment on attachment 34627 [details]
Fix "Reviewed by".
Rejecting patch 34627 from commit-queue. This patch will require manual commit.
Failed to run "['git', 'svn', 'dcommit']" exit_code: 1 cwd: None
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/WebCorePrefix.h Committed r47131 M WebCore/ChangeLog M WebCore/WebCorePrefix.h r47131 = e75e0df501e7cf6f156c0582d8339c21f55de469 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/47131 |