Bug 281961
| Summary: | To signal abort, if the reason is not given, set a new "AbortError" DOMException | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Marais Rossouw <me> |
| Component: | DOM | Assignee: | Marais Rossouw <me> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | All | ||
| OS: | All | ||
Marais Rossouw
In the DOM specification for the AbortSignal (see: https://dom.spec.whatwg.org/#abortsignal-signal-abort), point 2 states:
> Set signal's abort reason to the provided reason if given; otherwise, set it to a new "AbortError" DOMException.
We are not currently implementing this behavior. Instead, it's being handled in the IDL bindings for AbortController, which lacks any specification for signaling an abort.
If there is any internal code that calls `AbortSignal::signalAbort`, we should ensure it adheres to this DOM specification — and not leak this implementation detail.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Marais Rossouw
Pull request: https://github.com/WebKit/WebKit/pull/35618
EWS
Committed 285686@main (7d575e9f5b20): <https://commits.webkit.org/285686@main>
Reviewed commits have been landed. Closing PR #35618 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/138608498>