Bug 28193

Summary: bugzilla-tool: Re-factor shared landing logic into helper class to share more code
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 26715    
Attachments:
Description Flags
Patch v1 abarth: review+

Eric Seidel (no email)
Reported 2009-08-11 15:25:11 PDT
bugzilla-tool: Re-factor shared landing logic into helper class to share more code I did this originally a part of bug 26715, but it really should be a separate issue.
Attachments
Patch v1 (10.83 KB, patch)
2009-08-11 15:30 PDT, Eric Seidel (no email) 		abarth: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2009-08-11 15:30:08 PDT
Created attachment 34604 [details] Patch v1
Adam Barth
Comment 2 2009-08-11 15:33:07 PDT
Comment on attachment 34604 [details] Patch v1 Would be nice to factor out all the WebKit stuff into modules/webkit.py at some point.
Eric Seidel (no email)
Comment 3 2009-08-11 15:33:39 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKitTools/ChangeLog M WebKitTools/Scripts/bugzilla-tool Committed r47069 M WebCore/editing/haiku/EditorHaiku.cpp M WebCore/ChangeLog M WebCore/page/haiku/EventHandlerHaiku.cpp M WebCore/platform/haiku/ClipboardHaiku.cpp M WebCore/platform/haiku/DragDataHaiku.cpp r47068 = a6669f4fb846d758f172b3974b9f79bcd5242a69 (trunk) M WebKitTools/ChangeLog M WebKitTools/Scripts/bugzilla-tool r47069 = 67e74353dfc8c4855ce730e06c50d05018528641 (trunk) First, rewinding head to replay your work on top of it... Nothing to do. http://trac.webkit.org/changeset/47069
Note You need to log in before you can comment on or make changes to this bug.