Bug 281886
| Summary: | Raise exception when a webpushd connection error occurs | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ben Nham <nham> |
| Component: | WebKit Misc. | Assignee: | Ben Nham <nham> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ben Nham
When the connection to webpushd fails, we currently return a default-constructed response object. This often makes sense as a default, but in some cases (e.g. SubscribeToPushService), it does not. In that case it is causing us to return a PushSubscription object with an empty endpoint, which doesn't make sense to the client.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/138358189>
Ben Nham
Pull request: https://github.com/WebKit/WebKit/pull/35553
EWS
Committed 285610@main (a427fa53db75): <https://commits.webkit.org/285610@main>
Reviewed commits have been landed. Closing PR #35553 and removing active labels.
EWS
Committed 283286.520@safari-7620-branch (cb547545007c): <https://commits.webkit.org/283286.520@safari-7620-branch>
Reviewed commits have been landed. Closing PR #2313 and removing active labels.