Bug 281873
| Summary: | Update length check in appendQuotedJSONString to align with String's max length | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | daniel_liu4 |
| Component: | JavaScriptCore | Assignee: | Mark Lam <mark.lam> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | mark.lam, nth10sd, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
daniel_liu4
`appendQuotedJSONString` currently uses a CheckedUint32; however, the maximum length of a String is 2147483647, which is the bounds of an Int32. Thus, we should make sure that `appendQuotedJSONString` uses the correct bounds to avoid creating Strings past the maximum length.
rdar://138178439
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
daniel_liu4
Pull request: https://github.com/WebKit/WebKit/pull/35541
Mark Lam
Pull request: https://github.com/WebKit/WebKit/pull/35850
EWS
Committed 285840@main (0aa654672af4): <https://commits.webkit.org/285840@main>
Reviewed commits have been landed. Closing PR #35850 and removing active labels.
Mark Lam
*** Bug 280395 has been marked as a duplicate of this bug. ***