Bug 28180

Summary: [WML] WMLPageState is not allowed to store the active card, it needs to be done per document
Product: WebKit Reporter: Nikolas Zimmermann <zimmermann>
Component: WebCore Misc.Assignee: Nikolas Zimmermann <zimmermann>
Severity: Normal CC: staikos
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 20393    
Description Flags
Initial patch staikos: review+

Description Nikolas Zimmermann 2009-08-11 10:33:13 PDT
A WMLPageState may be reused for a new document, on the same Page object.
Thus the "WMLCardElement* activeCard" is not allowed to be stored there, leading to crashes under certain circumstances.

Going to past a patch soon, including a reproducable test for this.
Comment 1 Nikolas Zimmermann 2009-08-11 11:39:03 PDT
Created attachment 34580 [details]
Initial patch
Comment 2 Nikolas Zimmermann 2009-08-11 12:29:42 PDT
Sending        WebCore/ChangeLog
Adding         WebCore/manual-tests/wml/select-onpick-event-crash.wml
Sending        WebCore/wml/WMLCardElement.cpp
Sending        WebCore/wml/WMLDoElement.cpp
Sending        WebCore/wml/WMLDocument.cpp
Sending        WebCore/wml/WMLDocument.h
Sending        WebCore/wml/WMLGoElement.cpp
Sending        WebCore/wml/WMLPageState.cpp
Sending        WebCore/wml/WMLPageState.h
Sending        WebCore/wml/WMLPrevElement.cpp
Sending        WebCore/wml/WMLRefreshElement.cpp
Transmitting file data ...........
Committed revision 47048.