Bug 281710 – Convert basic shapes types to strongly typed CSS/Style values

• Component: CSS
• Status: RESOLVED FIXED

[Sam Weinig]

Convert basic shapes types to strongly typed CSS/Style values.

A bit more complicated than gradient, will require bringing in blending support.

[Sam Weinig]

Pull request: https://github.com/WebKit/WebKit/pull/35472

[Radar WebKit Bug Importer]

<rdar://problem/138601093>

[EWS]

Committed 285708@main (4692eacc698b): <https://commits.webkit.org/285708@main>

Reviewed commits have been landed. Closing PR #35472 and removing active labels.

[Jonathan Bedard]

Reopened Bugzilla.
REGRESSION (285708@main) Broke the macOS debug builds, tracking revert in https://bugs.webkit.org/show_bug.cgi?id=282127.

[Alex Christensen]

Could you please include this diff when re-landing?  It fixes TestWebKitAPI.IPCTestingAPI.SerializedTypeInfo:

diff --git a/Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in b/Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in
index 693f675b06f6..e2e34bad5904 100644
--- a/Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in
+++ b/Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in
@@ -3127,15 +3127,15 @@ using WebCore::Style::LengthPercentagePointAll = WebCore::Style::Point<WebCore::
 using WebCore::Style::LengthPercentagePointNonnegative = WebCore::Style::Point<WebCore::Style::LengthPercentageNonnegative>;
 
 [CustomHeader, Nested] struct WebCore::Style::CommaSeparatedVector<WebCore::Style::LengthPercentagePointAll> {
-    WebCore::Style::CommaSeparatedVector<WebCore::Style::LengthPercentagePointAll>::Vector value;
+    Vector<WebCore::Style::LengthPercentagePointAll> value;
 };
 [CustomHeader, Nested] struct WebCore::Style::CommaSeparatedVector<WebCore::Style::LengthPercentagePointNonnegative> {
-    WebCore::Style::CommaSeparatedVector<WebCore::Style::LengthPercentagePointNonnegative>::Vector value;
+    Vector<WebCore::Style::LengthPercentagePointNonnegative> value;
 };
 
 using WebCore::Style::ShapeCommand = std::variant<WebCore::Style::MoveCommand, WebCore::Style::LineCommand, WebCore::Style::HLineCommand, WebCore::Style::VLineCommand, WebCore::Style::CurveCommand, WebCore::Style::SmoothCommand, WebCore::Style::ArcCommand, WebCore::Style::CloseCommand>;
 [CustomHeader, Nested] struct WebCore::Style::CommaSeparatedVector<WebCore::Style::ShapeCommand> {
-    WebCore::Style::CommaSeparatedVector<WebCore::Style::ShapeCommand>::Vector value;
+    Vector<WebCore::Style::ShapeCommand> value;
 };
 
 header: <WebCore/StylePosition.h>
@@ -3345,6 +3345,7 @@ using WebCore::Style::CloseCommand = WebCore::Style::Constant<WebCore::CSSValueC
     std::variant<WebCore::Style::Large, WebCore::Style::Small> arcSize;
     WebCore::Style::Angle<WebCore::CSS::All> rotation;
 };
+using WebCore::Style::LengthPercentageSizeAll = WebCore::Style::Size<WebCore::Style::LengthPercentageAll>
 
 header: <WebCore/StyleBorderRadius.h>
 [CustomHeader, Nested] struct WebCore::Style::BorderRadius {
@@ -7518,6 +7519,8 @@ header: <WebCore/GraphicsContextState.h>
     WebCore::GraphicsContextState::Purpose m_purpose;
 };
 
+enum class WebCore::WindRule : bool
+
 [AdditionalEncoder=StreamConnectionEncoder] struct WebCore::SourceBrushLogicalGradient {
     std::variant<Ref<WebCore::Gradient>, WebCore::RenderingResourceIdentifier> serializableGradient();
     WebCore::AffineTransform spaceTransform;

[Sam Weinig]

Pull request: https://github.com/WebKit/WebKit/pull/35773

[EWS]

Committed 285966@main (060102d7428f): <https://commits.webkit.org/285966@main>

Reviewed commits have been landed. Closing PR #35773 and removing active labels.