Bug 281681

Summary:	Refactor Font::systemFallback to use a proper Font object placeholder
Product:	WebKit	Reporter:	Vitor Roriz <vitor.roriz>
Component:	Text	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	fantasai.bugs, vitor.roriz, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	Other
Hardware:	Unspecified
OS:	Unspecified

Vitor Roriz

Reported 2024-10-17 11:47:11 PDT

Font::systemFallback uses a -1 (0xfff...f) address to represent a Font pointer that is a system font fallback. This is later handled and allocated properly. This disables us for adopting RefPtr<Font> at some locations, since we can't create a RefPtr of an invalid address.

Attachments
Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2024-10-17 11:47:24 PDT

<rdar://problem/138132620>

Vitor Roriz

Comment 2 2024-10-17 12:08:37 PDT

Pull request: https://github.com/WebKit/WebKit/pull/35374

EWS

Comment 3 2024-10-17 17:45:09 PDT

Committed 285370@main (c3af7ac0c64b): <https://commits.webkit.org/285370@main> Reviewed commits have been landed. Closing PR #35374 and removing active labels.

Note You need to log in before you can comment on or make changes to this bug.