Bug 281590

Summary: Make text-box-edge inherited per spec update
Product: WebKit Reporter: fantasai <fantasai.bugs>
Component: CSSAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, ntim, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://github.com/web-platform-tests/wpt/pull/48722
Attachments:
Description Flags
Patch
none
[fast-cq]Patch none

fantasai
Reported 2024-10-16 10:49:49 PDT
CSSWG Resolution: Switch text-box-edge to be inherited. (text-box-trim remains non-inherited) Trimming uses the text-box-edge of the line box's containing block; or if trimming an inline box, the text-box-edge of the box itself.
Attachments
Patch (22.97 KB, patch)
2024-10-18 14:41 PDT, zalan 		no flags
DetailsFormatted DiffDiff
[fast-cq]Patch (22.97 KB, patch)
2024-10-20 14:15 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 2 2024-10-16 10:50:17 PDT
<rdar://problem/138049359>
Tim Nguyen (:ntim)
Comment 3 2024-10-16 22:57:25 PDT
Pull request: https://github.com/WebKit/WebKit/pull/35348
Tim Nguyen (:ntim)
Comment 4 2024-10-16 23:06:30 PDT
Submitted web-platform-tests pull request: https://github.com/web-platform-tests/wpt/pull/48662
zalan
Comment 5 2024-10-18 14:41:19 PDT
Created attachment 472990 [details] Patch
zalan
Comment 6 2024-10-20 14:15:33 PDT
Created attachment 472999 [details] [fast-cq]Patch
EWS
Comment 7 2024-10-20 16:29:27 PDT
Committed 285489@main (8b4bbd2c5bbf): <https://commits.webkit.org/285489@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 472999 [details].
EWS
Comment 8 2024-10-22 10:35:25 PDT
Committed 283286.337@safari-7620-branch (4b913046ccd5): <https://commits.webkit.org/283286.337@safari-7620-branch> Reviewed commits have been landed. Closing PR #2096 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.