Summary: | clicking below end of text in a textarea moves cursor to wrong position | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dan Winship <danw> | ||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | jmalonzo, xan.lopez | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | Linux | ||||||
Attachments: |
|
Description
Dan Winship
2009-08-10 10:44:06 PDT
Created attachment 38434 [details]
editingbehavior.patch
Turns out there's already a setting to control precisely this stuff, so just expose it and adjust our default value to be more GTK+-like.
Comment on attachment 38434 [details] editingbehavior.patch Hi Xan > +WebCore::EditingBehavior core(WebKitEditingBehavior type) > +{ > + return (WebCore::EditingBehavior)type; Is it possible to use c++ style casts here? > > +typedef enum { > + WEBKIT_EDITING_BEHAVIOR_MAC, > + WEBKIT_EDITING_BEHAVIOR_WINDOWS > +} WebKitEditingBehavior; Is it possible to add a COMPILE_ASSERT for these just in case of future changes? Thanks. r=me with those changes. (In reply to comment #3) > Thanks, committed as r47687 with those changes. This changed introduced a regression in the following test: editing/execCommand/toggle-compound-styles.html -> failed The change in http://trac.webkit.org/changeset/46920 might be helpful. I guess we need to rebaseline the test to match mac? (In reply to comment #4) > (In reply to comment #3) > > Thanks, committed as r47687 with those changes. > > This changed introduced a regression in the following test: > editing/execCommand/toggle-compound-styles.html -> failed > > The change in http://trac.webkit.org/changeset/46920 might be helpful. I guess > we need to rebaseline the test to match mac? Yeah, I just did this and the bot is green again, thanks! |