Bug 281537
| Summary: | Ensure InitializeWebKit2 is called before allocating API::Features in WebPreferencesFeatures.cpp | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | David Degazio <d_degazio> |
| Component: | WebKit Process Model | Assignee: | David Degazio <d_degazio> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | nham, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
David Degazio
It's possible to reach WebPreferencesFeatures::features() before initializing WebKit, for instance when initializing the SettingsMenu in awakeFromNib. We currently ensure WebKit is initialized before constructing any API object. But, before we can construct a Feature object, we need to first allocate a WTF::String, and we can do this before WTF::initialize() was called which can lead to issues. We should lazily initialize the feature list and ensure we have already initialized WebKit before beginning to construct the feature list.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/138003594>
David Degazio
Pull request: https://github.com/WebKit/WebKit/pull/35253
EWS
Committed 285293@main (ae4bc135bbb4): <https://commits.webkit.org/285293@main>
Reviewed commits have been landed. Closing PR #35253 and removing active labels.