Bug 281495
| Summary: | REGRESSION(283414@main): [WPE][GTK] Crash in ProcessLauncher socket monitor callback | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Michael Catanzaro <mcatanzaro> |
| Component: | WebKitGTK | Assignee: | Michael Catanzaro <mcatanzaro> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | berto, bugs-noreply, dimstar, mcatanzaro, mgorse |
| Priority: | P2 | ||
| Version: | Other | ||
| Hardware: | PC | ||
| OS: | Linux | ||
Michael Catanzaro
The socket monitor callback that I added in 283414@main accidentally deletes itself by calling m_socketMonitor.stop(). This causes the lambda capture to itself be deleted.
On x86_64, it works due to luck prior to https://github.com/WebKit/WebKit/pull/34133, where I finally noticed and fixed it. But it crashes on at least aarch64 and ppc64le. I need to split the fix out of that pull request so it can land separately without depending on a bunch of unrelated changes.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Michael Catanzaro
*** Bug 281565 has been marked as a duplicate of this bug. ***
Michael Catanzaro
There's a valgrind trace in bug #281565.
Michael Catanzaro
Pull request: https://github.com/WebKit/WebKit/pull/35297
Michael Catanzaro
*** Bug 281038 has been marked as a duplicate of this bug. ***
Michael Catanzaro
*** Bug 281666 has been marked as a duplicate of this bug. ***
EWS
Committed 285339@main (a28255d5d405): <https://commits.webkit.org/285339@main>
Reviewed commits have been landed. Closing PR #35297 and removing active labels.