Bug 28115

Summary: Inspector: Console Drawer is Toggling instead of Staying Open
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, timothy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Ensure The Drawer stays Open timothy: commit-queue+

Description Joseph Pecoraro 2009-08-08 15:15:04 PDT 
This is a regression. Typically when using the hotkey or clicking the error/warnings icon the console is forced open, but now if it is open these actions will toggle the console closed.
Comment 1 Joseph Pecoraro 2009-08-08 15:18:42 PDT 
Created attachment 34403 [details]
Ensure The Drawer stays Open

A new method Drawer.showView(view) ensures that:
  - The drawer will be open
  - The provided view will be showing
Comment 2 Eric Seidel (no email) 2009-08-11 12:37:45 PDT 
Comment on attachment 34403 [details]
Ensure The Drawer stays Open

Clearing review flag on attachment: 34403

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/inspector/front-end/Drawer.js
	M	WebCore/inspector/front-end/inspector.js
Committed r47049
	M	WebCore/ChangeLog
	M	WebCore/inspector/front-end/inspector.js
	M	WebCore/inspector/front-end/Drawer.js
r47049 = 5847ea6bf7fc1d9f761b3363a847a0978fc69389 (trunk)
No changes between current HEAD and refs/remotes/trunk
Resetting to the latest refs/remotes/trunk
http://trac.webkit.org/changeset/47049
Comment 3 Eric Seidel (no email) 2009-08-11 12:37:48 PDT 
All reviewed patches have been landed.  Closing bug.