Bug 280958
| Summary: | [site-isolation] RenderLayerBacking::updateAfterWidgetResize needs to notify cross-process subframe RenderLayerCompositors of bounds changing | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Matt Woodrow <mattwoodrow> |
| Component: | Layout and Rendering | Assignee: | Matt Woodrow <mattwoodrow> |
| Status: | RESOLVED WONTFIX | ||
| Severity: | Normal | CC: | bfulgham, commit-queue, simon.fraser, webkit-bug-importer, zalan |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 281269 | ||
| Bug Blocks: | |||
Matt Woodrow
The code currently only works with in-process subframes.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/137406024>
Matt Woodrow
Pull request: https://github.com/WebKit/WebKit/pull/34756
EWS
Committed 284932@main (3f1856724b13): <https://commits.webkit.org/284932@main>
Reviewed commits have been landed. Closing PR #34756 and removing active labels.
WebKit Commit Bot
Re-opened since this is blocked by bug 281269
Matt Woodrow
I reverted this because it causes visual rendering issues in http/tests/site-isolation/selection-focus.html, despite making the graphics layer dumps match.
It looks like in the site-isolation case, the RenderLayer for the <iframe> creates a 'contents' GraphicsLayer, and the relevant offset is set on that (and that layer isn't included in the dump).
For in-process iframes, there's no contents layer, just the child RenderView/RenderLayerCompositor, and we manually forward the offset down to it.
I don't think there's anything to fix here, unless we really need the layer trees to be identical (which is nice for testing, but probably doesn't matter).