Bug 280947

Summary: [FFC] Add support for column-gap value
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, ntim, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
[fast-cq]Patch none

alan
Reported 2024-10-06 09:09:09 PDT
ssia
Attachments
Patch (10.65 KB, patch)
2024-10-06 09:11 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (15.10 KB, patch)
2024-10-06 13:12 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (15.75 KB, patch)
2024-10-06 13:52 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (17.63 KB, patch)
2024-10-06 18:21 PDT, alan 		no flags
DetailsFormatted DiffDiff
[fast-cq]Patch (16.99 KB, patch)
2024-10-06 20:35 PDT, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2024-10-06 09:11:58 PDT
Created attachment 472832 [details] Patch
alan
Comment 2 2024-10-06 13:12:11 PDT
Created attachment 472834 [details] Patch
alan
Comment 3 2024-10-06 13:52:56 PDT
Created attachment 472836 [details] Patch
alan
Comment 4 2024-10-06 18:21:31 PDT
Created attachment 472838 [details] Patch
alan
Comment 5 2024-10-06 20:35:49 PDT
Created attachment 472839 [details] [fast-cq]Patch
EWS
Comment 6 2024-10-06 20:40:23 PDT
Committed 284748@main (239674d2ad94): <https://commits.webkit.org/284748@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 472839 [details].
Radar WebKit Bug Importer
Comment 7 2024-10-06 20:41:16 PDT
<rdar://problem/137401278>
Tim Nguyen (:ntim)
Comment 8 2024-10-07 06:48:01 PDT
Comment on attachment 472839 [details] [fast-cq]Patch View in context: https://bugs.webkit.org/attachment.cgi?id=472839&action=review > Source/WebCore/layout/formattingContexts/flex/FlexFormattingUtils.cpp:71 > +LayoutUnit FlexFormattingUtils::columnGapValue(const ElementBox& flexContainer, LayoutUnit flexContainercCntentBoxWidth) ditto :) > Source/WebCore/layout/formattingContexts/flex/FlexFormattingUtils.h:46 > + static LayoutUnit columnGapValue(const ElementBox& flexContainer, LayoutUnit flexContainercCntentBoxWidth); typo here too
Note You need to log in before you can comment on or make changes to this bug.