Bug 280945
Summary: | [Skia] Add build option to toggle SK_DEBUG | ||
---|---|---|---|
Product: | WebKit | Reporter: | Adrian Perez <aperez> |
Component: | CMake | Assignee: | Adrian Perez <aperez> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | ||
Priority: | P2 | ||
Version: | WebKit Local Build | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Bug Depends on: | |||
Bug Blocks: | 268972 |
Adrian Perez
We may want to enable SK_DEBUG sometimes while working on Skia code,
to catch issues using its API which would go silently ignored (or end
up in incorrect results) when SK_RELEASE is enabled. Still, we do NOT
want to have SK_DEBUG enabled in general with DEVELOPER_MODE=ON, nor
for CMAKE_BUILD_TYPE=Debug|RelWithDebInfo -- we want a separate option
to control it separately.
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Adrian Perez
Pull request: https://github.com/WebKit/WebKit/pull/34744
EWS
Committed 284742@main (480ca7310445): <https://commits.webkit.org/284742@main>
Reviewed commits have been landed. Closing PR #34744 and removing active labels.