Bug 280943

Summary: [FFC] Add support for row-gap value
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, ntim, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
[fast-cq]Patch none

alan
Reported 2024-10-06 05:57:48 PDT
ssia
Attachments
Patch (12.26 KB, patch)
2024-10-06 06:00 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (12.24 KB, patch)
2024-10-06 07:52 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (12.23 KB, patch)
2024-10-06 09:07 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (12.23 KB, patch)
2024-10-06 12:08 PDT, alan 		no flags
DetailsFormatted DiffDiff
[fast-cq]Patch (11.59 KB, patch)
2024-10-06 13:31 PDT, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2024-10-06 06:00:10 PDT
Created attachment 472828 [details] Patch
alan
Comment 2 2024-10-06 07:52:54 PDT
Created attachment 472830 [details] Patch
alan
Comment 3 2024-10-06 09:07:26 PDT
Created attachment 472831 [details] Patch
alan
Comment 4 2024-10-06 12:08:50 PDT
Created attachment 472833 [details] Patch
alan
Comment 5 2024-10-06 13:31:01 PDT
Created attachment 472835 [details] [fast-cq]Patch
EWS
Comment 6 2024-10-06 13:36:06 PDT
Committed 284743@main (e7b4f98ae25b): <https://commits.webkit.org/284743@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 472835 [details].
Radar WebKit Bug Importer
Comment 7 2024-10-06 13:37:16 PDT
<rdar://problem/137388349>
Tim Nguyen (:ntim)
Comment 8 2024-10-07 06:46:30 PDT
Comment on attachment 472835 [details] [fast-cq]Patch View in context: https://bugs.webkit.org/attachment.cgi?id=472835&action=review > Source/WebCore/layout/formattingContexts/flex/FlexFormattingUtils.cpp:62 > +LayoutUnit FlexFormattingUtils::rowGapValue(const ElementBox& flexContainer, LayoutUnit flexContainercCntentBoxHeight) typo: flexContainercCntentBoxHeight
Note You need to log in before you can comment on or make changes to this bug.