Bug 28085 – Unnecessary 'goto' confuses flow of control in WebHTMLView

• Component: Platform
• Status: RESOLVED CONFIGURATION CHANGED

[Jens Alfke]

I was just looking through WebHTMLView and found this strange code in the -namesOfPromisedFilesDroppedAtDestination: method:

- (NSArray *)namesOfPromisedFilesDroppedAtDestination:(NSURL *)dropDestination
{
    NSFileWrapper *wrapper = nil;
    NSURL *draggingImageURL = nil;
    
    if (WebCore::CachedImage* tiffResource = [self promisedDragTIFFDataSource]) {
        
        SharedBuffer *buffer = static_cast<CachedResource*>(tiffResource)->data();
        if (!buffer)
            goto noPromisedData;
        
        ...
    }
noPromisedData:
    
There's no reason to use a goto there; maybe there was once some complex code in between the goto and the label, but not currently. It can easily be simplified to:

        if (buffer) {
            ...
        }
    }

[Ahmad Saleem]

I am unable to find 'goto' as of today:

https://searchfox.org/wubkat/source/Source/WebKitLegacy/mac/WebView/WebHTMLView.mm#4343

I think this might have changed over the years and this can be marked as 'RESOLVED CONFIGURATION CHANGED'?

@Alexey - no idea, who would be right person to conclude on this.