Bug 280830
| Summary: | [Cocoa] File descriptor leak in createTemporaryZipArchive() | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Olivier Blin <olivier.blin> |
| Component: | Web Template Framework | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | ahmad.saleem792, cdumez, darin, ggaren, loic.yhuel, sihui_liu, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Olivier Blin
In Source/WTF/wtf/cocoa/FileSystemCocoa.mm, createTemporaryZipArchive() creates a file descriptor with mkstemp(), but it does not use the return value.
It should close the file descriptor to avoid a leak.
This has been seen by Loïc when reviewing bug 277734.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/137212920>
Olivier Blin
Pull request: https://github.com/WebKit/WebKit/pull/34767
EWS
Committed 284770@main (82751285ecd3): <https://commits.webkit.org/284770@main>
Reviewed commits have been landed. Closing PR #34767 and removing active labels.