WebInspector: Move object properties read / write access into InjectedScript

• Component: Web Inspector (Deprecated)
• Status: RESOLVED FIXED

[Pavel Feldman]

Now that styles are edited entirely by means of InjectedScript, it is time to migrate Objects to use the same schema.

[Pavel Feldman]

Created attachment 34309 [details]
patch

[Timothy Hatcher]

Comment on attachment 34309 [details]
patch


> -WebInspector.ObjectPropertiesSection = function(object, title, subtitle, emptyPlaceholder, ignoreHasOwnProperty, extraProperties, treeElementConstructor)
> +WebInspector.ObjectRef = function(objectId, path, protoDepth)

I think this should go into a new file and not ObjectPropertiesSection.js, since it is used in other places and not specific to the ObjectPropertiesSection.

I am not too fond of the Ref suffix. Do you like ObjectProxy better?

> +    this.objectId = objectId;

You should add a comment about this, this looks temporary.

> +    this.path = path || [];

> +InjectedScript._objectForId = function(objectId)
> +{
> +    return objectId;
> +}

You hould add a comment about this being temporary.

[Pavel Feldman]

Created attachment 34321 [details]
patch

(In reply to comment #2)
> (From update of attachment 34309 [details])
> 
> 
> I think this should go into a new file and not ObjectPropertiesSection.js,
> since it is used in other places and not specific to the
> ObjectPropertiesSection.
> 

Done.

> I am not too fond of the Ref suffix. Do you like ObjectProxy better?
>

Done.
 
> 
> You should add a comment about this, this looks temporary.
>

Done (added TODO).
 
> 
> You hould add a comment about this being temporary.


Done (added TODO).

[Timothy Hatcher]

Comment on attachment 34321 [details]
patch

> diff --git a/WebCore/inspector/front-end/ObjectProxy.js b/WebCore/inspector/front-end/ObjectProxy.js
> \ No newline at end of file

Add a newline.

[Dimitri Glazkov (Google)]

Pfeldman wants to land it himself.

[Pavel Feldman]

	M	WebCore/ChangeLog
	M	WebCore/WebCore.vcproj/WebCore.vcproj
	M	WebCore/inspector/front-end/ConsoleView.js
	M	WebCore/inspector/front-end/DOMAgent.js
	M	WebCore/inspector/front-end/InjectedScript.js
	M	WebCore/inspector/front-end/ObjectPropertiesSection.js
	A	WebCore/inspector/front-end/ObjectProxy.js
	M	WebCore/inspector/front-end/PropertiesSidebarPane.js
	M	WebCore/inspector/front-end/ScopeChainSidebarPane.js
	M	WebCore/inspector/front-end/WebKit.qrc
	M	WebCore/inspector/front-end/inspector.html
Committed r46972

[David Kilzer (:ddkilzer)]

This fix caused Bug 32442.